Merged
Conversation
| use Doctrine\DBAL\Driver\FetchUtils; | ||
| use Doctrine\DBAL\Driver\Result; | ||
| use Doctrine\DBAL\Driver\Result as DriverResult; | ||
| use Doctrine\DBAL\Result; |
Member
There was a problem hiding this comment.
Is having a Doctrine\DBAL\Result in $result on purpose instead of a Driver\Result and planned for 3.0?
Member
Author
There was a problem hiding this comment.
Yes. The caching layer only works with the wrapper-level result. Prior to this change, the wrapper result would implement the driver result interface, so this signature would work. As of this change, it's no longer true.
Additional references:
- The same is true for the wrapper Connection and Statement classes as of Do not implement driver-level interfaces by wrapper-level classes #4159.
- We may rework the caching layer into a driver-level middleware where it belongs but it's not a top priority for me. See Rework the portability layer to act as a middleware #4157, there's basically a similar issue here.
SenseException
previously approved these changes
Sep 25, 2020
Member
SenseException
left a comment
SenseException
left a comment
There was a problem hiding this comment.
If the answer to my previous question is "yes", this then this is ready for merge IMO.
morozov
force-pushed
the
remove-abstraction-result
branch
2 times, most recently
from
5b38026 to
4f57b1d
Compare
morozov
force-pushed
the
remove-abstraction-result
branch
from
4f57b1d to
496bd71
Compare
SenseException
approved these changes
Sep 26, 2020
greg0ire
approved these changes
Sep 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interface is proposed for deprecation in #4291.